Specifying encrypted_max_length instead of max_length in models

foundertherapy / django-cryptographic-fields

A set of fields that wrap standard Django fields with encryption provided by the python cryptography library.

MIT License

29 stars 34 forks source link

Specifying encrypted_max_length instead of max_length in models #15

Closed mrname closed 8 years ago

mrname commented 8 years ago

This is intended to resolve #11 by asking the user to specify encrypted_max_length in their models instead of max_length. The user has the option of still using the old method of max_length with the side effect of migrations being produced every time makemigrations is run. This seemed reasonable to me since some users might not care (if they have a small app that only requires an initial migration).

mrname commented 8 years ago

LOL, just noticed that #7 addresses this issue in a slightly more reasonable way. Feel free to close this pull in favor of that one. Whatever fixes this most appropriately!

danaspiegel commented 8 years ago

@mrname no problem. closing this pull request.

mrname commented 8 years ago

Thanks @danaspiegel. In light of closing this, are there any plans for merging #7 any time soon?