This pull request proposes a change to the ProjectCompileOutput impl by creating a method set_compiled_artifacts. The modification is required for the usage of extending foundry to work with non-solc compilers like zksolc for zkSync.
Context:
Currently, the compiled_artifacts field is marked as pub(crate), making it accessible only within the same crate. This encapsulation poses a limitation when the struct is used as part of a larger build process where access to compiled_artifacts is needed to be modified. Providing a set method to update compiled_artifacts it the proposed solution.
Rationale:
In effort to extend foundry support to zkSync ecosystem, the ability to set the modified Artifact is needed. You can see where we make use of set_compiled_artifactshere.
Enhanced Flexibility: Providing set_compiled_artifacts allows for more flexible post-compilation processes, including custom artifact handling, storage, and modifications tailored to specific use cases.
Functionality Impact:
The proposed change will have no impact on existing functionality. It merely extends the accessibility of the compiled_artifacts field, enabling external crates to utilize the compiled bytecode. This change is backward-compatible and does not alter the behavior of any existing code that depends on the ProjectCompileOutput struct.
Motivation
This pull request proposes a change to the
ProjectCompileOutput
impl by creating a methodset_compiled_artifacts
. The modification is required for the usage of extendingfoundry
to work with non-solc compilers likezksolc
for zkSync.Context:
Currently, the
compiled_artifacts
field is marked aspub(crate)
, making it accessible only within the same crate. This encapsulation poses a limitation when the struct is used as part of a larger build process where access tocompiled_artifacts
is needed to be modified. Providing a set method to updatecompiled_artifacts
it the proposed solution.Rationale:
In effort to extend
foundry
support to zkSync ecosystem, the ability to set the modified Artifact is needed. You can see where we make use ofset_compiled_artifacts
here.set_compiled_artifacts
allows for more flexible post-compilation processes, including custom artifact handling, storage, and modifications tailored to specific use cases.Functionality Impact:
The proposed change will have no impact on existing functionality. It merely extends the accessibility of the
compiled_artifacts
field, enabling external crates to utilize the compiled bytecode. This change is backward-compatible and does not alter the behavior of any existing code that depends on theProjectCompileOutput
struct.Solution
Solution:
PR Checklist