search

foundry-rs / foundry-fork-db

Apache License 2.0
33 stars 9 forks source link

Add sharedbackend blocking behaviour #3

Closed mattsse closed 3 months ago

mattsse commented 3 months ago

the current backend makes use of tokio's block in place per db request: https://github.com/foundry-rs/foundry-fork-db/blob/fd94eb5876da5afab266156c71654c49a304e338/src/backend.rs#L637-L644

this is inefficient, especially if the value is already cached, but convenient if used inside tokio.

we can make this configurable via some enum that determines if it should use block_in_place or not.

nkysg commented 3 months ago

May I take this?

Ethanol48 commented 3 months ago

I want to contribute to the project, can I get assigned to this issue?

I'll try to come up with a PR this evening.