Closed PaulRBerg closed 1 year ago
This PR fixes the issue reported by @mds1 and @davidlaprade here:
https://github.com/gitcoinco/Alpha-Governor-Upgrade/pull/12
I'm sorry guys, I messed up the cache implementation. It looks like the tilde symbol ~ is not available in Node.js. I had to use os.homedir() instead of ~/. Proof that this works now:
~
os.homedir()
~/
https://github.com/PaulRBerg/foundry-template/actions/caches
I ran the new implementation in my foundry-template a few dozen times to make sure that it works properly now. See a few screenshots below.
On the bright side, this issue didn't cause any trouble to end users. It just didn't do the caching, that's all - it didn't save any bogus cache.
This PR fixes the issue reported by @mds1 and @davidlaprade here:
https://github.com/gitcoinco/Alpha-Governor-Upgrade/pull/12
I'm sorry guys, I messed up the cache implementation. It looks like the tilde symbol
~
is not available in Node.js. I had to useos.homedir()
instead of~/
. Proof that this works now:https://github.com/PaulRBerg/foundry-template/actions/caches
I ran the new implementation in my foundry-template a few dozen times to make sure that it works properly now. See a few screenshots below.
On the bright side, this issue didn't cause any trouble to end users. It just didn't do the caching, that's all - it didn't save any bogus cache.