search

foundry-rs / foundry

Foundry is a blazing fast, portable and modular toolkit for Ethereum application development written in Rust.
https://getfoundry.sh
Apache License 2.0
7.91k stars 1.6k forks source link

EIP1559/legacy artifacts #3598

Open odyslam opened 1 year ago

odyslam commented 1 year ago

Component

Forge

Have you ensured that all of these are up to date?

What version of Foundry are you on?

forge 0.2.0 (70f4fb5 2022-11-02T00:05:06.592613Z)

What command(s) is the bug in?

forge script

Operating System

macOS (Apple Silicon)

Describe the bug

When developing parseJson helpers to automatically parse forge-script artifacts:

Seeing some artifacts from a chain that I know doesn't support EIP1559 and it has the gas field without the gasPrice, as you would expect from a LegacyTransaction. It could be that their RPC returns the info incorrectly, so there is nothing forge can do.

Basically, I deployed to MilkomedaC1, which is not EIP1559 but got EIP1559-type artifacts.

mds1 commented 1 year ago

@odyslam What exactly is the issue here? This sounds like an issue with the MilkomedaC1 RPC and not forge?

odyslam commented 1 year ago

@mds1, if I remember correctly, for some reason, several nonERC1559 chains produced ERC1559 artifacts. I will need to investigate again.