search

foundry-rs / foundry

Foundry is a blazing fast, portable and modular toolkit for Ethereum application development written in Rust.
https://getfoundry.sh
Apache License 2.0
8.06k stars 1.65k forks source link

meta(parsing): tracking issue for JSON / TOML parsing + writing #3801

Open odyslam opened 1 year ago

odyslam commented 1 year ago
mds1 commented 1 year ago

@odyslam what's the status of this issue? The second item is checked off but issue is opened, so I'm not certain

sakulstra commented 1 year ago

@mds1 the issue with array escaping is still present for sure (just faced on latest forge std and stumbled over this issue)

mds1 commented 1 year ago

@odyslam got another one for you here: https://github.com/foundry-rs/foundry/issues/4601

odyslam commented 1 year ago

@sakulstra can you elaborate a bit on the array escaping issue and share your code. More use-cases I have, the easier it's to solve this.

I need to prioritize some time to work on these issues

sakulstra commented 1 year ago

@odyslam I refactored the code to no longer use arrays :sweat_smile:

That said, you can reproduce with this hash 3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7 on https://github.com/bgd-labs/aave-helpers/tree/feat/config-snapshot-v2 by running forge test (json is written to reports folder)

It's this function: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L78 writing an array e.g. here: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L299

mds1 commented 1 year ago

Got another one from forge-std, full list is below. I haven't triaged these yet, i.e. there may be duplicates, etc.