By skipping immutables, do you mean we don't check the immutables that are embedded in the runtime code?
If yes, then NO; we do check them. Runtime codes are compared entirely.
Got it, in general I think that's the better and stronger approach. To take a step further, you can do: if no constructor arguments are passed AND no API key is passed (so forge has no constructor args), then it skips checking immutables. That would help cases like https://github.com/foundry-rs/foundry/issues/8617. In this case you would also want to include a message in the output indicating this difference
klkvr
commented
2 months ago
Got it, in general I think that's the better and stronger approach. To take a step further, you can do: if no constructor arguments are passed AND no API key is passed (so forge has no constructor args), then it skips checking immutables. That would help cases like https://github.com/foundry-rs/foundry/issues/8617. In this case you would also want to include a message in the output indicating this difference
Originally posted by @mds1 in https://github.com/foundry-rs/foundry/issues/8510#issuecomment-2278225473