Remove feature that makes inclusion of "fail" in test name cause the test to always fail.

foundry-rs / foundry

Foundry is a blazing fast, portable and modular toolkit for Ethereum application development written in Rust.

https://getfoundry.sh

Apache License 2.0

8.34k stars 1.77k forks source link

Remove feature that makes inclusion of "fail" in test name cause the test to always fail. #9218

Closed mgiagante closed 3 weeks ago

mgiagante commented 4 weeks ago

Component

Forge

Describe the feature you would like

Currently, including the word "fail" in the name of a test makes the test always expect a revert. This is counter intuitive as some users might add this word in the test name to describe the intent of the case or the scenario under test.

Unless there is a strong case for keeping this, its removal would make forge test more intuitive.

Additional context

No response

mgiagante commented 4 weeks ago

I want to volunteer to fix this. Feel free to assign it to me if you want. Thanks!

zerosnacks commented 3 weeks ago

This is a breaking change with DappTools compatibility that we are intending to make after the V1 release

grandizzy commented 3 weeks ago

Closing this one as dupe of https://github.com/foundry-rs/foundry/issues/4437