Closed yash-atreya closed 2 weeks ago
I checked again the ticket and I think we got this wrong when discussed action, looks like the proposal is just to add 2 more sigs to make UX better but keep existings @zerosnacks could you also double check please
function mockCall(address where, bytes4 data, bytes calldata retdata) external; function mockCall( address where, uint256 value, bytes4 data, bytes calldata retdata ) external;
You are correct, this should be additive - not deprecating the current implementation
looks good, I'll push a change to make the same for vm.mockCallRevert
sigs and then merge if OK with you @yash-atreya
Woot, thank you all!
Motivation
Closes #9213
Solution
bytes4 data
arg to pass the selector liketoken.balanceOf.selector
instead ofabi.encodeWithSelector