search

foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.
https://foundry-rs.github.io/starknet-foundry/
MIT License
308 stars 150 forks source link

Unify Stark and Secp curve interfaces #1257

Closed drknzz closed 9 months ago

drknzz commented 10 months ago

The StarkCurve and Secp256 Curve interfaces should be unified into a single one.

Probably also adding a generic to secret_key.

#[derive(Copy, Drop)]
struct KeyPair<SK, PK> {
    secret_key: SK,
    public_key: PK,
}

_Originally posted by @MaksymilianDemitraszek in https://github.com/foundry-rs/starknet-foundry/pull/1242#discussion_r1410575978_

Also, please address the following:

piotmag769 commented 10 months ago

@drknzz remember about labels 🙏