Add a test for `get_call_trace` in cairo where `CallResult::Failure(CallFailure::Error(_))` is returned as call result - Githubissues

foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.

https://foundry-rs.github.io/starknet-foundry/

MIT License

320 stars 167 forks source link

Add a test for `get_call_trace` in cairo where `CallResult::Failure(CallFailure::Error(_))` is returned as call result #1990

Open piotmag769 opened 6 months ago

piotmag769 commented 6 months ago

Which components does the task require to be changed? (think hard pls)

snforge

Description

If a test failed in backend (unrecoverably) e.g. bcs of internet connection then https://github.com/foundry-rs/starknet-foundry/blob/d703c665f06def5361e36c2258980c4020c6ed47/snforge_std/src/trace.cairo#L57 is used in result of get_call_trace. We don't have a test for that in https://github.com/foundry-rs/starknet-foundry/blob/d703c665f06def5361e36c2258980c4020c6ed47/crates/forge/tests/integration/trace.rs#L385

Arcticae commented 5 months ago

@piotmag769 please describe this so it's more comprehensible