foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.
https://foundry-rs.github.io/starknet-foundry/
MIT License
308 stars 150 forks source link

docs: update snforge version #2086

Closed TAdev0 closed 4 months ago

TAdev0 commented 5 months ago

Introduced changes

Updates snforge version in Getting Started of the documentation

TAdev0 commented 4 months ago

hi @Arcticae i just noticed versions where outdated in the book, pushed this pr to update it. I have no idea why tests keep failing as i'm just modifying a .md file. any idea?

it seems to be related to the SEPOLIA_RPC_URL during CI

Arcticae commented 4 months ago

@TAdev0 seems you need to set up the URL for sepolia for the tests in the env variables (in your fork). That's why they are failing https://foundry-rs.github.io/starknet-foundry/development/environment-setup.html#environmental-variables

You can try using a public sepolia endpoint

TAdev0 commented 4 months ago

oh sorry my bad... will do that, thanks!

TAdev0 commented 4 months ago

@Arcticae i'm closing the issue, its not a big deal anyway ^^

I populated a .env file with :

SEPOLIA_RPC_URL="https://starknet-sepolia.public.blastapi.io/rpc/v0_7"

also tried:

SEPOLIA_RPC_URL=https://starknet-sepolia.public.blastapi.io/rpc/v0_7

and with a nethermind public endpoint as well.

I still have failing tests locally (4), dont know what the issue is

My errors are like

| error: Plugin diagnostic: Expected fork config must be of the form `url: <double quote string>, block_id: <snforge_std::BlockId>`.
|  --> [..]/src/lib.cairo[..]
|     #[fork(url: "https://lib.com")]
|  --> [..]/tests/test_fork.cairo[..]
| #[fork(url: "https://test.com")]
|       ^***********************^
| 
| error: Plugin diagnostic: Expected fork config must be of the form `url: <double quote string>, block_id: <snforge_std::BlockId>`.
|  --> [..]/tests/test_fork.cairo[..]
| #[fork(url: "https://starknet-sepolia.public.blastapi.io/rpc/v0_7", block_id: BlockId::Number(Latest))]
-       ^*****************************************************************************^
| error: Plugin diagnostic: Expected fuzzer config must be of the form `runs: <u32>, seed: <u64>`
|  --> [..]/tests/test_fuzzer.cairo[..]
| #[fuzzer(test: 10)]
|         ^********^
Arcticae commented 4 months ago

@TAdev0 we will investigate and probably update dox to make it easier for people - thanks for the interest in contribution nonetheless :)