Revert env changes - Githubissues

foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.

https://foundry-rs.github.io/starknet-foundry/

MIT License

279 stars 139 forks source link

Revert env changes #2178

Closed Arcticae closed 3 weeks ago

Arcticae commented 4 weeks ago

Closes #2172

Introduced changes

Reverts the changes that were needed to extract testing RPC URL from envs

Checklist

[x] Linked relevant issue
[x] Updated relevant documentation
[x] Added relevant tests
[x] Performed self-review of the code
[x] Added changes to CHANGELOG.md

Draggu commented 4 weeks ago

Im not sure if we want to revert all changes made there. Keeping url in one place is good idea. Previously we had it copy pasted all over making troubles when bumping rpc version. We can keep this changes while reverting env related ones only

Arcticae commented 4 weeks ago

@Draggu yeah probably that's a good point, was a bit lazy here :P