Use felt! for constants.rs. Delete parse_number and use .parse() - Githubissues

foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.

https://foundry-rs.github.io/starknet-foundry/

MIT License

279 stars 139 forks source link

Use felt! for constants.rs. Delete parse_number and use .parse() #2198

Closed ksew1 closed 3 weeks ago

ksew1 commented 3 weeks ago

Related https://github.com/foundry-rs/starknet-foundry/issues/1854 Related https://github.com/foundry-rs/starknet-foundry/pull/2188

Introduced changes

Change base_clash_hashes from &str to FieldElement to avoid parsing them at runtime
Delete parse_number and use .parse() method of FieldElement as both do the same.

Checklist

[x] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[x] Performed self-review of the code
[ ] Added changes to CHANGELOG.md