foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.
https://foundry-rs.github.io/starknet-foundry/
MIT License
279 stars 138 forks source link

Revamp `account add` procedure #2218

Open Arcticae opened 2 weeks ago

Arcticae commented 2 weeks ago

Which components does the task require to be changed? (think hard pls)

sncast

Description

  1. We should probably name it account import since it imports an account
  2. We should have a visual guide (with screenshots) on how to do it from (argent/braavos/oz)
  3. We should have a separate section for this in the documentation (preferably "Importing accounts from wallets?")
  4. We should probably also cover how to import an account to a wallet
  5. We should remove RPC URL and class hash (they are probably not needed - this needs to be verified thoroughly)
  6. We should support configuring global keystores and leaving them in cast GLOBAL configuration (same concept as #2212), to have them as first class citizen as well (this can be deprecated in the future as UAFF gains adoption, but for now keystore should have better UX)
Arcticae commented 1 week ago

Marking as blocked by #2221