foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.
https://foundry-rs.github.io/starknet-foundry/
MIT License
328 stars 177 forks source link

Updating packages name for the plugin and release hotfixes of versions `0.28.0` to `latest` #2564

Open cptartur opened 1 month ago

cptartur commented 1 month ago

In future versions Scarb (from sometime after 2.8.3) will require plugins to have the same name in Scarb.toml and `Cargo.toml.

Update names in https://github.com/foundry-rs/starknet-foundry/blob/72ea785ca354e9e506de3e5d687da9fb2c1b3c67/crates/snforge-scarb-plugin/Scarb.toml#L2 and https://github.com/foundry-rs/starknet-foundry/blob/72ea785ca354e9e506de3e5d687da9fb2c1b3c67/crates/snforge-scarb-plugin/Cargo.toml#L2 so they match and both use _ instead of -.

Additionally, create a release hotfix versions (X.Y.1) of foundry from 0.28.0 to latest including just the changes outlined above so that we maintain backwards compatibility for them.

cptartur commented 1 month ago

Apparently Scarb might just show a warning initially if these don't match, so we might do without releasing for the time being.