foundry-rs / starknet-foundry

Blazing fast toolkit for developing Starknet contracts.
https://foundry-rs.github.io/starknet-foundry/
MIT License
324 stars 177 forks source link

Migrate all scarb packages to support `edition = "2024_07"` #2651

Open kkawula opened 2 weeks ago

kkawula commented 2 weeks ago

Which components does the task require to be changed? (think hard pls)

snforge, sncast

Description

Migrate all scarb packages to support edition = "2024_07"

Sollution: for each

Related: https://github.com/foundry-rs/starknet-foundry/issues/2632

enehizy commented 2 weeks ago

Mind if I take this issue?

OWK50GA commented 2 weeks ago

Could I take on this issue?

mexes20 commented 2 weeks ago

Hello, I’d like to be assigned to work on this.

ETA: 15 hours

pheobeayo commented 2 weeks ago

I'd love to give this a go.

ShantelPeters commented 2 weeks ago

Please can I be assigned to this issue

PedroRosalba commented 2 weeks ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

How I plan on tackling this issue

pheobeayo commented 1 week ago

On it! thank you for the task.

franciszekjob commented 1 week ago

Hi @pheobeayo , just wanted to check out on your progress. Do you need any assistance 😄 ?

pheobeayo commented 1 week ago

@franciszekjob I am working on it, but how do I build successfully locally?

franciszekjob commented 1 week ago

but how do I build successfully locally?

Just run snforge test in the package.

franciszekjob commented 1 week ago

Hi @pheobeayo , how's the progress :) ?

pheobeayo commented 1 week ago

@franciszekjob still fixing the 507 bugs after changing the edition....

I have tried fixing some but still couldn't make the file public like this lib.cairo was initially like image but I decided to make it public like this image but still couldn't compile.....

Any clue to that

franciszekjob commented 6 days ago

@pheobeayo I see you're updating edition in snforge_std. I think we can address this specific package in other PR, as it may require more work. So let's limit the scope to update edition in all packages, apart of snforge_std, ok?

pheobeayo commented 4 days ago

okay

pheobeayo commented 4 days ago

@franciszekjob Kindly check out the PR I created yesterday, I updated the edition in all packages apart from the snforge_std