Add extra dice to Foundry's Dice Configuration menu

foundryvtt-dcc / dcc

Foundry Tabletop System for Dungeon Crawl Classics RPG

MIT License

32 stars 20 forks source link

Add extra dice to Foundry's Dice Configuration menu #420

Closed mclemente closed 1 month ago

mclemente commented 1 month ago

This PR adds the extra dice used on DCC to the Dice Configuration menu, which should allows users to choose their preferred rolling method.

It overwrites the original CONFIG.Dice.fulfillment.dice to make sure the dice are displayed in order. Otherwise, d2, d3, d5, etc would show up after d100.

Caveat: Font Awesome has no icons for d7, d14, d16, d24, d30.

mooped commented 1 month ago

Thanks for the PR.

If Foundry supports using images as icons in addition to Font Awesome (looks like it does), I contributed a set of SVG icons for DCC Dice to Dice Tray that we could maybe use.

mclemente commented 1 month ago

Foundry supports it. I've tried to add them, but it is a bit tricky since Font Awesome's icons are fonts, so img and div with masks require some new styling, and I wasn't sure you'd want the extra icons for a menu that might be used once or twice.

cyface commented 1 month ago

Thanks! I updated the icons and styled them in our dev-0.46.0 branch, and this will go out with that.