Proposal: Rename `data.skills.<skl>.value` to `data.skills.<skl>.proficient`

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).

MIT License

303 stars 206 forks source link

Proposal: Rename `data.skills.<skl>.value` to `data.skills.<skl>.proficient` #1003

Open schultzcole opened 3 years ago

schultzcole commented 3 years ago

The current naming is, in my opinion, confusing and does not semantically represent this property's function very well. In addition, making this change would make skills consistent with the proficient property of abilities.

I realize this would be a pretty big breaking change, so maybe it's not worth the trouble.

schultzcole commented 3 years ago

Originally in GitLab by @aaclayton

I like the suggestion of supporting both, I think my only main concern would be active effects (or modules like DAE) which currently provide a temporary proficiency boost to a skill that would no longer function since they would no longer be targeting the source data.

schultzcole commented 3 years ago

Originally in GitLab by @arbron

Would it be possible to move the data over to .proficient and then use derived data to mirror it over to .value to keep compatibility (for the time being at least)?