search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
335 stars 224 forks source link

Regression on #1140, Parenthetical Rolls Do Not Crit Correctly #2343

Open Skyl3lazer opened 1 year ago

Skyl3lazer commented 1 year ago

Ref: #1140

When rolling an expression with parentheses, crits do not work correctly. For example, (1d10), (1d10 + 5), or (1d10+5) + (1d10+5) will not roll additional dice (using base crit rules).

Use case: In addition to the original issue's example, this makes it hard to tag damage values. (1d10+5)[fire] will show the entire value as fire type damage in the chat log, but then the damage cannot crit. This is also useful with multipart damage, i.e. (1d10+5)[fire] + (1d10+5)[cold].

Workaround: It is possible to do 1d10[fire] + 5[fire] + 1d10[cold] + 5[cold] but this is obviously more cumbersome and isn't the natural way to write these rolls. It's also possible to split in to multiple rolls with mixed damage types, but that is also more cluttered and awkward in the chat.

Fyorl commented 1 year ago

I think a fully robust solution to this will have to wait for the better dice handling we have coming in v12.

Skyl3lazer commented 5 months ago

I'd link to bump this again since V12 is going to be launched soon and is in final testing :)

Fyorl commented 5 months ago

I'd link to bump this again since V12 is going to be launched soon and is in final testing :)

We can't use the improved v12 dice functionality until we drop support for v11 in the system.