search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
331 stars 219 forks source link

Mayor Concern/Issue: Colorblindness UI #2860

Open pontusedberg opened 8 months ago

pontusedberg commented 8 months ago

FoundryVTT and the Dnd5e system have pressed this issue for faaaar to long that it have caused a massive concern and issue among the colourblind community, I have mild Achromatopsia, Meaning I have trouble seeing Grey on an other shade of grey. We need to have UI build into dnd5e Core system, So colour correction programs/modules can use it better.

It would also be great to just have that option in settings (and easy to see/find for us colour impaired folks) Right now all I see, is just a grey smudge on the char sheet, Image provided here: NewSheet the new sheet is at least a step in the direction compared to to old sheet. OldSheet

But we still need an option/ways to correct the UI Colours and fonts Lots of love

HarryWraith commented 8 months ago

I second this. As someone with only 10% vision my needs won't be met by a tick box approach to accessibility. I need to have proper control over contrast, font size, font style etc. While there are modules out that help, this should be part of core functionality.

pontusedberg commented 8 months ago

I second this. As someone with only 10% vision my needs won't be met by a tick box approach to accessibility. I need to have proper control over contrast, font size, font style etc. While there are modules out that help, this should be part of core functionality.

This is quite important to discuss as well, I seen a few comments that says "oh just install xxx module or vxv module" Its not a viable option, every time there is an update to Dnd5e core, Those modules break and require weeks to update. And also it requires a GM to install those mods for us, which limits the amount of games we can play on.

pontusedberg commented 8 months ago

Refrence1 Adding this Reference picture so you may see what the Char sheet Used to look like with TidyUI module (now forever abounded and broken) Compared to the old CharSheet, With my vision disability.

arbron commented 8 months ago

@pontusedberg @HarryWraith I've added two issues to help address this.

On the short term, I've done some work on respecting increase contrast settings from the OS using the prefers-contrast media query. If you want to check out this PR I've filed and offer any feedback on the screenshots for areas where you think it can still be improved for your usage: https://github.com/foundryvtt/dnd5e/pull/2866 (currently only covers the character sheet, but I'll work on a second PR to address chat card issues).

I've also been working on a theme picker to support the light/dark mode toggle in the interface, but it is extensible to support additional themes beyond those two. That will probably be a 3.1.0 feature, but when it is in place we can add a more specialized colorblindness theme to go beyond what the increase contrast mode provides.

If you find other places in the new design that are particularly lacking beyond what you've posted above, definitely post some screenshots here so we can be sure to address those either in increase contrast mode or in the new themes.