Active effect remaining duration does not update immediately on character sheet

[schultzcole]

Repro:

• Add a character to a combat.
• Apply an active effect to the character from a chat card.
• Open the actor's character sheet and observe the remaining duration on the newly applied effect.
• Advance the combat to the start of the next round.
• Observe that the remaining duration is unchanged.
• Close and reopen the actor's sheet and observe that the duration is now correct.

If you just leave the sheet open, the duration on the sheet will update correctly the next time the actor becomes the active combatant because that's when the actor itself is updated and therefore the sheet is re-rendered.

[schultzcole]

This is kind of a tough one. The issue is that nothing on the effect is actually getting updated, since the remaining duration is computed based on the current world time and the start time of the effect, so the sheet doesn't know that it should re-render.

The only solution I can think of right now is to hook on combatRound from the sheet and re-render if the actor has any active effects with a duration.startTime. This should work, but I worry that it could increase the likelihood of people losing edits due to a sheet re-render that happened because the combat turn changed. Might be safer to wait for Applications V2 so we can selectively re-render the effects tab when the combat round updates.