search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
332 stars 222 forks source link

damage modification physical bypasses not functioning #3429

Closed etiquettestartshere closed 6 months ago

etiquettestartshere commented 6 months ago

Steps to reproduce: give an actor (in my case, Morthos (Tiefling Sorcerer)) -10 Slashing damage modification, and check Magical under physical bypasses. Give an actor (in my case, Aoth (Human Druid)) a magical weapon, in my case a Dancing Longsword from the SRD. After damage with the longsword is rolled, as the GM, apply the damage with the damage application tray to the actor with damage modification: only damage over 10 will apply, meaning the bypass is not functioning.

The same problem seems to exist if the damage modification and related bypass is applied as an active effect (I also tried with adamantine).

image image

tposney commented 6 months ago

I noticed this in my game on the weekend. There should be a test for bypasses when deciding to apply dm. I added this at line in my game and it seems to work.

      // Apply type-specific damage reduction
      if ( !ignore("modification", d.type) && traits.dm?.amount[d.type] && (traits.dm.bypasses?.size === 0 || (traits.dm.bypasses?.intersection(d.properties)?.size ?? 0) === 0)) {