foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
321 stars 218 forks source link

Unable to resize item sheets #4239

Open Pbmarsh opened 2 weeks ago

Pbmarsh commented 2 weeks ago

Hi, I'm combining these as one issue ticket, as either one would fix the issue in question, but please let me know if they should be separated.

Beyond this just being an annoyance on it's own, the main direct impact this is having for me right now is that if I have too many modules enabled which add functionality to items (such as all of the modules I had activated before), the top of the item sheet just completely disappears. In this first screen shot I have 3 modules activated that add buttons to the top of the sheet, and as you can see this is getting cut off, but not completely. image In this screenshot I have activated an additional module that adds a button, so 3 seems to be the (rough) limit - that said I suspect things like the title of the item, source of the item, and whether it's a magical item with a magical rune seem to also impact it. image My reason for believing this is here's a screenshot of the arrows sheet as a point of comparison, with the same number of modules activated as in the first screenshot: image

As a result, it seems I'm now limited by how many modules I can have activated at once - while this could be fixed by raising issues with the individual module developers, I personally believe that even if this wasn't affecting the modules, the inability to resize the window would still be an annoying limitation, and fixing it on the system side of things would inherently solve the module side of things.

JPMeehan commented 2 weeks ago

The no-legacy issue is something that's an intentional change, per the patch notes

The legacy sheets are no longer available, as making them available would have required us to duplicate all the additional work done to the V2 sheets in order to support Activities.

I agree that the system should add resizability to the sheets, at least until the eventual AppV2 refactor shoves all those window buttons into a dropdown.

Pbmarsh commented 2 weeks ago

The no-legacy issue is something that's an intentional change, per the patch notes

The legacy sheets are no longer available, as making them available would have required us to duplicate all the additional work done to the V2 sheets in order to support Activities.

I agree that the system should add resizability to the sheets, at least until the eventual AppV2 refactor shoves all those window buttons into a dropdown.

Noted - I have changed the title

M0nk3yy commented 2 weeks ago

I think overflow handling is the issue here rather than the need for resizable sheets. If a full header was spread onto a second line for example, that would provide a usable experience.

I think it is worth noting that the biggest space hog in your example is your Source field, not the number of modules. Generally these are listed using an abbreviations (SRD, TCoE, etc.). For example I can use 3 sheet header mods here without issue:

image

But adding a single extra X causes the overflow because it has become too lengthy.

Regardless, obviously this is an issue that needs better handling, especially when the buttons disappear entirely.

JPMeehan commented 2 weeks ago

Yeah, I don't really want to edit hundreds of items because the spacing standards on the source field changed — I ran into this with zero modules on my copy of the Beastheart class with the source "Beastheart and Monstrous Companions"

Pbmarsh commented 2 weeks ago

I think overflow handling is the issue here rather than the need for resizable sheets. If a full header was spread onto a second line for example, that would provide a usable experience.

I think it is worth noting that the biggest space hog in your example is your Source field, not the number of modules. Generally these are listed using an abbreviations (SRD, TCoE, etc.). For example I can use 3 sheet header mods here without issue:

image

But adding a single extra X causes the overflow because it has become too lengthy.

Regardless, obviously this is an issue that needs better handling, especially when the buttons disappear entirely.

Yeah I came across this same work around last night - by removing the source from several items I tested with, I was able to get all of my module buttons to appear. But as JPMeehan has said, doing that for each item will be a massive pain - hopefully it's something that can be fixed in some way for the next update!

krbz999 commented 2 weeks ago

A long label like "Icewind Dale: Rime of the Frostmaiden" will make the buttons completely inaccessible. WotC makes long book names. This is likely affecting a lot of people at the moment.

JPMeehan commented 2 weeks ago

Especially since there weren't any conventions or standards for what the Source: Book field meant or how it was used really prior to this update.