search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
321 stars 218 forks source link

Item Activities should include the Base Damage Type if none is specified in the Attack Damage Details tab. #4393

Open w15p opened 1 week ago

w15p commented 1 week ago

Certain Features (such as Monk's Martial Arts) allow for an override of an Item's damage formula. That override includes the Item's Base Damage Type and if a new Type is not specified, will result in a damage roll that has no type.

so, Item Activities should include the Base Damage Type if none is specified in the Attack Damage Details tab.

eg, the Monk Attack shown below should inherit whatever the Base Damage Type was for the weapon (in this case, it was a Scimitar, so it should be Slashing): Screenshot 2024-09-22 at 1 08 20 PM

currently, it has to be manually set to work properly: Screenshot 2024-09-22 at 12 57 32 PM

trioderegion commented 1 week ago

The idea of "none" damage being an intrinsically invalid state, which signals to the damage workflow that it should find the "nearest appropriate damage type(s)", may also serve to address #3754 in a more holistic manner.

The above approach would also address https://github.com/foundryvtt/foundryvtt-premium-content/issues/755