foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
337 stars 225 forks source link

[BUG] Spell Attack Bonuses from Enchantment Activity are not Applied #4429

Closed Hopelite closed 1 month ago

Hopelite commented 1 month ago

I try to apply effect with system.bonuses.msak.attack and system.bonuses.rsak.attack increases via Enchantment Activity (I'm implementing Artificer's "Enhanced Arcane Focus" infusion). However, enchanted this way items with this effect do not change the spell rolls, unlike to items with the same effect, but set manually.

Steps to reproduce

  1. Create a Feature with an Enchantment Activity.
    1. In the Effects tab Add any value to system.bonuses.msak.attack attribute.
    2. The same for system.bonuses.rsak.attack attribute.
    3. Do not apply any restrictions to the Activity. image
  2. Grant this Feature to an Actor.
  3. Use this feature and drag any item into the chat template (like Staff): image
  4. Equip the item for the Actor.
  5. Use any spell with either "Ranged Spell Attack" or "Melee Spell Attack" attack type Activity.

Expected result: the attack roll is increased by the system.bonuses.msak.attack or system.bonuses.rsak.attack value of the created effect. Actual result: both melee and ranged spell attacks do not have the system.bonuses.msak.attack or system.bonuses.rsak.attack value applied: image

Additional Info

System version: 4.0.3 Foundry VTT version: 12 Build 331

If the same effect was added manually to an item, not granted by an Enchantment Activity: image

All bonuses are applied correctly: image

hakr14 commented 1 month ago

Effects to be added to the item like this need to be added as Additional Effects (or "Rider Effects") in the enchantment: image

Hopelite commented 1 month ago

Thank you for the quick answer! I definitely overlooked this field's purpose somewhere in the docs. Closing the issue.