search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
322 stars 218 forks source link

Updating to v4 breaks weapons with multiple damage types #4511

Open flogiston1 opened 20 hours ago

flogiston1 commented 20 hours ago

Updating to version 4 (from version 3.3.1 to 4.0.4 specifically for me) doesn't migrate weapons with two damage types correctly. Problem is that only the first row of damage gets migrated to the new weapon (both base item, and attack activity), and second row disappears. This seems to affect weapons only, or at least on features it works as should.

I tested this with custom copies (not from srd compendium) of flame tongue and a death knight, of which flame tongue deals slashing and fire damage, and death knight has two features dealing dual damage: his sword and hellfire orb. Hellfire orb gets migrated correctly, but his sword loses it's necrotic damage. Flame tongue also deals only slashing after migration, and fire damage has disappeared.

Gave named examples so I don't have to explain as much, tested it on some other stuff too with similar results. These were tested as imported to a world, and this does seem to affect both things in world and in compendiums (after running migration scripts on those).

flogiston1 commented 6 hours ago

Just to add, I don't know if this only affects weapons, but at least doesn't seem to affect features. I did not do extensive testing though.