foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
339 stars 226 forks source link

Redesign Advancement applications using ApplicationV2 & V2 styles #4708

Open arbron opened 1 week ago

arbron commented 1 week ago
JPMeehan commented 1 week ago

Bugfix request as part of this - Handlebars and textareas are tricky, could the whitespace please be fixed for the hints? I believe {{~> 'my-partial}} for partials and {{~value~}} for value references would help resolve the tab/indentation issues.

arbron commented 3 days ago

Bugfix request as part of this - Handlebars and textareas are tricky, could the whitespace please be fixed for the hints? I believe {{~> 'my-partial}} for partials and {{~value~}} for value references would help resolve the tab/indentation issues.

Is that actually an issue anywhere in the system? All our usage of <textarea> have no extra space (e.g. <textarea>{{ var }}</textarea>, so if any weird spacing is occurring it isn't from the system.

JPMeehan commented 3 days ago

The hint field entry for advancements

arbron commented 3 days ago

The hint field entry for advancements

Again, no space there:

<textarea name="hint" {{~#if default.hint}} placeholder="{{ default.hint }}"{{/if}}>{{ hint }}</textarea>
JPMeehan commented 3 days ago

The issue is if the value has spaces, e.g. I copy from a PDF with line breaks. I'm on mobile but it's easy to reproduce