search

foundryvtt / dnd5e

An implementation of the 5th Edition game system for Foundry Virtual Tabletop (http://foundryvtt.com).
MIT License
339 stars 226 forks source link

[#4714] Fix error when using chat action for deleted activity #4719

Closed arbron closed 1 week ago

arbron commented 1 week ago

Fixes an issue caused by enlarging special bastion facilities to their maximum size, which caused the Enlarge activity to be removed, and thus no subsequent chat actions could be triggered.

This fix covers the immediate problem, but the chat actions will still not be usable if the player refreshes or the chat message is re-rendered, because this fix only works because the deleted activity is still held in memory as part of the event handler.

Closes #4714

arbron commented 1 week ago

@Fyorl This is a temporary fix that solves some of the problem, but there should probably be a better fix involving how we handle the ephemeral activities on bastion facilities.

arbron commented 1 week ago

Closed in favor of https://github.com/foundryvtt/dnd5e/pull/4750