foundryvtt / foundryvtt-premium-content

Public issue tracking for feature requests and bug reports related to first-party premium content for Foundry Virtual Tabletop.
https://foundryvtt.com/packages/premium
17 stars 1 forks source link

[Bug]: Phandelver and Below - many items with missing or incorrect properties #515

Closed krbz999 closed 4 months ago

krbz999 commented 7 months ago

What happened?

A lot of items are not set up completely.

Most egregious example is the Staff of Defense:

image

Along with that,

Additionally seems like some of them should be consumable, not loot (Emboldening Brandy for example).

Side note: Consider a shorthand for the book title?

image

(Dragonguard, bee-tee-dubs, seems to have text pasted with formatting).

image

image

image

A weapon such as Lightbringer should never have a damage formula written in the "Other" field. This prevents the damage from being rolled as critical. The system is limited in this regard obviously, but it would, at least, be functional in the 'Versatile' field. The same is true for the Javelin of Lightning.

Also no magic items have a note in the description explaining their type, rarity, and attunement requirements (e.g., "Weapon (mace), uncommon (requires attunement)").

Incorrect source:

image

This one has actually lost some properties that exist in the SRD; the Magical property, and system.proficient being the wrong value. The fact that it is initially unidentified when imported but has no Unidentified description is a minor footnote.

image

image

image

The 'Periapt of Health' item has no effect granting immunity to diseased. It's SRD, though, and the issue is there as well, which is probably why. It's also not marked as Magical, but the SRD item is.

The 'Ring of the Orator' is not set up at all. It has no properties whatsoever.

image

Usually weapons have no target or just "1 creature", but I guess 'creature or object' is not technically incorrect...

image

The "Blessing of the Solipsistic Mind" has an effect that transfers to the actor by default (and disabled), making duration tracking impossible.

An item will not recover uses when set to charges/dawn/dusk if there is no formula placed in the 'Recovery Formula' field. In this case, the formula should be '1', or it should simply be set to 'Day' instead of 'Dawn'.

image

What package are you reporting this for?

Phandelver and Below: The Shattered Obelisk

Version

1.1.0

Relevant log output

No response

aaclayton commented 7 months ago

Thank you for the comprehensive report

DM-DK commented 7 months ago

In addition, it looks like the prices of magic items are being pulled from the SRD compendium, which is set up with homebrew pricing. Magic item prices should fall within DMG or Xanathar ranges or, preferably, not be included at all. There are other mods we can use if we need homebrew.

Also noticed that the Illustrated Book on Ropers has a price of 2000 gp, but none is listed in the adventure.