Closed silvative closed 5 months ago
I've addressed all of the "big" ones on my first list as well as a few more in the latest commit for v 1.1.0, but I didn't touch the "extra" ones, so I'll leave this issue later to gather more and then maybe do another round in the future.
Files changed:
Before/after example:
A few portraits seem to have slightly non-ideal cropping, to varying degrees, and could benefit from another pass.
Egregious example to illustrate the point (most are not this bad) :
In many cases, the issue isn't extra white space but imbalanced introduced by (eg) a shadow or outstretched arm, in which case it's harder to fix but could be remedied with a bit of a reframing.
To spot these, it can help to go to the thumbnail view:
I did a quick scan and here are some I've noticed it on:
EDIT: Above have been resolved, below have not
Borderline cases (some of these are fine when you open them in more detail and only look imbalanced in the thumbnail):
The issue is minor and purely aesthetic, so I'll let these accumulate a little before I do a single sweep through.
Tangentially, it may be worth looking into a system PR to adjust how the thumbnails in the compendium browser appear. Even a small change can help: