foundryvtt / foundryvtt-premium-content

Public issue tracking for feature requests and bug reports related to first-party premium content for Foundry Virtual Tabletop.
https://foundryvtt.com/packages/premium
15 stars 1 forks source link

[Bug]: "Advance Sundial of Aten" macro no longer works in v12 #571

Open Daeke opened 3 months ago

Daeke commented 3 months ago

What happened?

The existing macro looks like this: const dial = canvas.scene.lights.get("ozpgBI74DdbovJIM"); dial.update({rotation: dial.data.rotation + 5}); game.time.advance(1200);

When clicked, the console error below is thrown.

I believe this just needs to have dial.data.rotation changed to dial.rotation and it should work?

What package are you reporting this for?

The Demon Queen Awakens

Version

4.0.0

Relevant log output

VM2811:4 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'rotation')
    at Macro.eval (eval at #executeScript (foundry.js:19863:16), <anonymous>:4:34)
    at #executeScript (foundry.js:19868:17)
    at Macro.execute (foundry.js:19815:35)
    at Hotbar._onClickMacro (foundry.js:81883:20)
    at HTMLLIElement.dispatch (jquery.min.js:2:40035)
    at v.handle (jquery.min.js:2:38006)
anathemamask commented 3 months ago

I verified this was functioning just yesterday, so I suspect that this issue results from not reimporting the adventure in v12. Can you do so and let me know if it works after that? :)

BPtacek commented 3 months ago

Sadly, not working. New world, V12 + Pathfinder 2e v6 beta 3

Daeke commented 3 months ago

Yes, I verified this originally on a brand new Foundry install with a new world and import. I haven’t checked on the latest PF beta but I see the user above me has.

Daeke commented 3 months ago

Reverified on a fresh install: Foundry 12.327 PF2e v6.0.0-beta3 Demon Queen v4.0.1