foundryvtt / foundryvtt

Public issue tracking and documentation for Foundry Virtual Tabletop - software connecting RPG gamers in a shared multiplayer environment with an intuitive interface and powerful API.
https://foundryvtt.com/
192 stars 10 forks source link

TinyMCE editor has incorrect font sizes #10801

Closed CarlosFdez closed 2 weeks ago

CarlosFdez commented 2 weeks ago

What happened?

Font sizes looked a little off when editing, and I realized its because the default body text's font is too big.

(We can't swap to prosemirror while there's still outstanding bugs with it, the menu overflow clipping being the biggest one)

What ways of accessing Foundry can you encounter this issue in?

Reproduction Steps

I also verified in simple worldbuilding system.

image

What core version are you reporting this for?

12.320

Relevant log output

None really, but --font-size-X properties existed in V11 but not in V12 for the mce.css.

Bug Checklist

aaclayton commented 2 weeks ago

Hey @Fyorl a small one I hope you can look at. Sounds like there might be a related issue with ProseMirror that would be blocking PF2E adoption of the "go-forward" editor also.

Fyorl commented 2 weeks ago

Sounds like there might be a related issue with ProseMirror that would be blocking PF2E adoption of the "go-forward" editor also.

(We can't swap to prosemirror while there's still outstanding bugs with it, the menu overflow clipping being the biggest one)

If #8212 is the menu clipping issue then I don't see how it could be related to this one.

CarlosFdez commented 2 weeks ago

I need to be better at responding to notifications.

The menu clipping issue is why we're still bothering with tinymce. This is a tinymce bug. I brought up the prosemirror bug because usually the response to using tinymce is "please swap to prosemirror" so I pre-emptively replied :P

Even our own devs talk about swapping and we have to keep linking to that issue.