Remove trailing question marks from certain data model field labels, for example `Is Darkness Source?` or `Restricts Light?` no longer present the field label with a question mark.

foundryvtt / foundryvtt

Public issue tracking and documentation for Foundry Virtual Tabletop - software connecting RPG gamers in a shared multiplayer environment with an intuitive interface and powerful API.

https://foundryvtt.com/

202 stars 10 forks source link

Remove trailing question marks from certain data model field labels, for example `Is Darkness Source?` or `Restricts Light?` no longer present the field label with a question mark. #10866

Closed unsoluble closed 1 month ago

unsoluble commented 1 month ago

User Experience

This element should be just Darkness Source.

(See #7914 for previous question-mark removals for precedent.)

Tack-on tweak: Should probably also be "...light and vision, and suppresses lights and vision sources..."

Oh, also, these in the Tile > Overhead app:

and these in the Configure Default Token Settings app:

and this in the Combat Tracker Settings app:

unsoluble commented 1 month ago

Missed the ones in the hint text here (which will also need to be rephrased a bit):

aaclayton commented 1 month ago

The policy I thought to apply here is that field labels are not phrased as questions, but I think that question marks in hint text is not inappropriate. I'll keep this in mind if we want to rework it as we gradually redesign these apps for v2.

unsoluble commented 1 month ago

Totally fine if that's the style you want to go for, of course, but I was ticketing as a matter of global consistency — the question-phrasing was removed from hint text too in 7914, and doesn't appear in any other places in the UI.