search

foundryvtt / foundryvtt

Public issue tracking and documentation for Foundry Virtual Tabletop - software connecting RPG gamers in a shared multiplayer environment with an intuitive interface and powerful API.
https://foundryvtt.com/
202 stars 10 forks source link

Ambience filter effects are not applied to the background color of the Scene #10927

Closed CarlosFdez closed 4 weeks ago

CarlosFdez commented 1 month ago

What happened?

The purple token tinting is incredibly powerful to the point where we had to reduce dark scene luminosity in preCreate (to 0, but now I'm considering -0.25) because people thought it was a bug. Reset to defaults unfortunately foils that plan though, because the defaults are hardcoded.

image

A closer look image

Something to consider though is how it looks on a real map. For example alaustin in in the discord posted this example. Undoing the tint on just the tokens will look like weird behavior. The actual solution is beyond me, but perhaps altering the default works well as a short term bandaid?

Foundry_Virtual_Tabletop_RkxbWwYEC3-1

What ways of accessing Foundry can you encounter this issue in?

Reproduction Steps

Make a new scene, then transition it to darkness. Create a new actor and place on the scene. Create a new light source and place on the scene.

What core version are you reporting this for?

12.322

Relevant log output

No response

Bug Checklist

aaclayton commented 4 weeks ago

we had to reduce dark scene luminosity in preCreate (to 0, but now I'm considering -0.25)

I think the visual phenomenon you are commenting on here is more related to hue intensity rather than luminosity.

CarlosFdez commented 4 weeks ago

The luminosity slider in the environmental dark settings seems to be what triggers this behavior. Reducing it to -0.25 from -0.5 renders mystery man in light visible again. It could be that hue intensity uses luminosity to compute the result though?

dev7355608 commented 4 weeks ago

The issue is that the ambience filter effects are not applied to the background color of the scene. This is what it's supposed to look like: image

Norc commented 4 weeks ago

To clarify, this issue was only occurring when no background image was set.

CarlosFdez commented 4 weeks ago

Ah, so there was a bug, we just didn't id it right! Tbh I wondered if this was the real issue, but I only vaguely suspected it and moved on. Awesome! Thanks for fixing.