Skinstitch salve missing rule element and effect is expired on application

foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.

https://foundryvtt.com/packages/pf2e

Apache License 2.0

418 stars 349 forks source link

Skinstitch salve missing rule element and effect is expired on application #10788

Closed carpebiem closed 11 months ago

carpebiem commented 1 year ago

The rule element for upgrading the success to a crit success is missing:

Provided by esheyw { "key": "AdjustDegreeOfSuccess", "selector": "medicine", "adjustment": { "success": "one-degree-better" }, "predicate": [ { "or": [ "action:treat-wounds", "action:battle-medicine" ] } ] }

Also, the effect is currently set for null rounds so is expired when applied, so a duration should be given

simonward commented 1 year ago

Changes to APG items are frozen until remaster.

dellatorreadrian commented 12 months ago

Working on it (to get it ready when it can be merged)

dellatorreadrian commented 12 months ago

@TikaelSol

Just helping remember to close this issue due to this merged PR: https://github.com/foundryvtt/pf2e/pull/11324