Include damage predicates when predicating roll notes for damage rolls

[MrVauxs]

It would be great to create Rule Elements that predicate upon dealing damage of a specific type. For example, creating a Note for everytime you roll vitality damage.

There seems to already exist a "damage:type:vitality" string in the code, but it does not work either as a selector or predicate.

[stwlam]

Remove the predicate.

[CarlosFdez]

Does DamageAlteration suffice to increase already existing vitality damage? Would an upgrade there help with that?

[MrVauxs]

It was discussed on discord that having general rule options for damage types would be beneficial for other effects.

By this point I just want to create a Note RE that triggers whenever you roll any amount of vitality damage.

Altering Damage wont help here for my specific use case (unless the system is capable of only doing that for half that damage to another type, so 50% Vitality 50% Fire for example).

[stwlam]

At this point I really don't understand what you're asking for

[MrVauxs]

A way to predicate on rolling vitality damage. Ex. damage:type:vitality becoming a selector or predicate that you can actually use, as its apparently created in code already but never added to Roll Options or any actionable elements.

[CarlosFdez]

From discord discussion, this is a case of not being clear. Vauxs seems to want to spawn a note in damage rolls when certain types of damage occur, and would like the modifier specific roll options to be available for note predication.

[MrVauxs]

I will note that this also applies to inline damage rolls. Despite being able to roll for example @Damage[1[fire]], it does not give any information on it dealing fire damage.