foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
423 stars 352 forks source link

Feature request: other icon for marked Focus pool point #16922

Open robinsving opened 1 month ago

robinsving commented 1 month ago

We have the marked Focus pool point

We can see it: https://github.com/foundryvtt/pf2e/blob/405478740fa523c01271598d1e3491c89a0a64fd/static/templates/actors/character/tabs/spellcasting.hbs#L88

fa-solid fa-dot-circle

I'd like this to be changed to e.g. <i class="fa-regular fa-circle-xmark"></i> as that makes it easier to understand what it means.

robinsving commented 1 month ago

image vs image

AFigureOfBlue commented 1 month ago

I feel like the current one (the top of the two images you've posted) is the more intuitive one to me, and also the easier of them to read at a glance ('filled in' vs 'not filled in' reads more quickly to my eye than 'with an x' and 'without an x'). Could you share a bit more about in what ways you find the alternative you've presented to be easier to understand?

CarlosFdez commented 1 month ago

Veto from my end to the proposed solution though I'm amenable to alternative icons. Ideally a nested but filled in thick circle would be the most ideal to me. Right now its just a thicker donut, but I'd like the donut hole to be filled in personally.

robinsving commented 1 month ago

The solid one looks like it is full and the empty one is, well, empty, hence my confusion (i.e. "the pool is empty if the icons are empty"). I am also fine with any other option, but the current one has given me in-play issues more than once.

CarlosFdez commented 1 month ago

You're the only one I've heard have that issue. I would expect more likely that that left click to remove and right click to add created more issues than that.

CrackJackFlood commented 1 month ago

You're the only one I've heard have that issue. I would expect more likely that that left click to remove and right click to add created more issues than that.

Me and my players often get tripped up by it, never complained because its kind of insignificant, suggestions would be to copy how Hero Points look but instead have a F instead of a H or have it be a number (though I imagine most people prefer the visuals of pips I personally would prefer numbers for resources)

CrackJackFlood commented 3 weeks ago

F_1-8 H-8

@CarlosFdez I made these mock ups I can do a whole alphabet/symbols of icons for the system like this. I use FA H icon as inspiration for the font style.

robinsving commented 2 weeks ago

I like that design, it would be a lot clearer ~The fact that the Hero Point design is in total opposite to the Focus Pool design may actually be what trips me up: Example: HP are increased from left to right, while FP are decreased from left to right~

AFigureOfBlue commented 2 weeks ago

In those screenshots it's showing 1 hero point and 1 focus point remaining, not 1 and 2. If you were to hit "cast" on one of the focus spells it would remove the one filled-in focus pool dot, the same way as using a hero point to reroll a check would remove the one filled-in hero point dot.

I'm not opposed to changing the focus point icon to be an "F" like shown above, I just wanted to clarify that the two designs do currently operate in the same way as one another.

robinsving commented 2 weeks ago

Ah, ignore my last comment. Got confused by the icons again :)