foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
420 stars 349 forks source link

Magic Immunity Doesn't Work #17240

Open 7H3LaughingMan opened 1 week ago

7H3LaughingMan commented 1 week ago

It looks like IWR is looking for magical when calculating IWR; however, it's impossible to setup magical immunity because the option for immunities is magic. However, for weaknesses and resistances it's magical. I could fix the underlying problem; however, I think this would require a migration which I don't know how to do because creatures are setup with magic immunities so they would need to be changed to magical.

https://github.com/foundryvtt/pf2e/blob/498dd946ccf924f9bc4c4830289bdcf4bf312f76/src/module/actor/data/iwr.ts#L106

https://github.com/foundryvtt/pf2e/blob/498dd946ccf924f9bc4c4830289bdcf4bf312f76/src/scripts/config/iwr.ts#L67

DamianLyszczarczyk commented 2 days ago

I believe I had a case today that one of my player casted Caustic Blast at a wisp with magic immunity and the damage was applied to it normally.

CarlosFdez commented 2 days ago

magical immunity is not the same as magic immunity.

Magical immunity would give immunity to strikes from weapons with runes. Magic immunity is probably paizo's way of saying "spell-like". This is GM arbitrated, foundry cannot control this.

You do not want magical immunity to exist. This is a whyzo.