search

foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
399 stars 333 forks source link

Ranged weapons need their range increment to be displayed [REPLACEMENT ISSUE] #1769

Closed cswendrowski closed 1 year ago

cswendrowski commented 2 years ago

The original issue

Id: 1769
Title: Ranged weapons need their range increment to be displayed

could not be created. This is a dummy issue, replacing the original one.In case the gitlab repository still exists, visit the following link to see the original issue:

https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/issues/1769

cswendrowski commented 2 years ago

In GitLab by @jaypeedaylee on Nov 3, 2021, 15:25

I've actually started to tackle this. Not sure if I should add additional traits to the trait list and add them individually to the weapon or start looking for a way to just bring the already pre-filled Range in to the traits list

FoundryVTT_4eh4leR3k6

cswendrowski commented 2 years ago

In GitLab by @TMun on Nov 3, 2021, 15:29

@CarlosFdez or @stwlam can you talk with @jaypeedaylee to make sure that it's inline direction-wise? Don't want them to do work that won't fit, but happy to have someone do work that does :D

cswendrowski commented 2 years ago

In GitLab by @jaypeedaylee on Nov 4, 2021, 23:03

Feel free to hit me up on Discord, my name is Flash Granola in the Foundry server as well as the PF2e Foundry Server.

I've attempted to approach this in a couple ways

The first idea is as shown above where I added static Range and Reload entires to the weaponTraits in config.ts and used the existing description names such as PF2E.WeaponRange20 or PF2E.Reload0 to display the proper text. This was a pretty easy add, however it requires editing every ranged weapon and adding the new traits from the trait list.

Ultimately this solution feels sort of redundant since the Range and Reload values already exist.

So my other thought was to use the existing values in the item sheet for Reload and Range and somehow have those values render as if they were traits. However I don't know enough about the code or the system to understand how these values are attached to a weapon so I'm lost in the code trying to understand the workflow

Either way, definitely interested in getting the range and reload values to be part of the weapon data

cswendrowski commented 2 years ago

In GitLab by @CarlosFdez on Nov 5, 2021, 18:33

I thought @stwlam was already handling this? There's an MR that's up that we're waiting on the next cycle to merge in.

To be honest I'm not sure if its the same thing, or related, or different but will conflict.

cswendrowski commented 2 years ago

In GitLab by @jaypeedaylee on Nov 5, 2021, 19:16

Well if that's the case, I'll work on a different issues!

cswendrowski commented 2 years ago

In GitLab by @stwlam on Nov 18, 2021, 15:14

Weapon and attack rolls now show this; just need to add it to the actions tab of the PC sheet

cswendrowski commented 2 years ago

In GitLab by @jaypeedaylee on Nov 22, 2021, 15:03

If it won't crowd screen real estate too much, could Reload values be added also?

stwlam commented 1 year ago

Resolved at some point!