search

foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
399 stars 333 forks source link

Death saves inconsistency #325

Closed cswendrowski closed 2 years ago

cswendrowski commented 4 years ago

In GitLab by @federico.car88 on May 8, 2020, 06:56

Recovery checks DC from the Dying button always report success or failure relative to a DC of 10 rather than whatever the DC is currently set as (or DC 9 if the character has Toughness).

Screen_Shot_2020-05-08_at_9.18.07_pm

Screen_Shot_2020-05-08_at_9.51.35_pm

cswendrowski commented 4 years ago

In GitLab by @TMun on May 12, 2020, 22:09

Toughness_Dying

Looks like there is an issue just normally as well. Arshea and I were playing around with it. Toughness seems to subtract X from Dying X instead of 1 from dying X. Displayed math looks correct but logic is failing somewhere.

cswendrowski commented 4 years ago

In GitLab by @meditatingCybermind on May 12, 2020, 22:20

I think we may have missed the mark. issue appears to be that dying reduces the DC to 9, across the board

actor.js:245 is doing const recoveryMod = getProperty(this.data.data.attributes, 'dying.recoveryMod') || 0;

However attributes.dying.recoveryMod is null -- dying contains

"attributes": {
        "dying": {
          "value": 0,
          "max": 4
        },
cswendrowski commented 4 years ago

In GitLab by @yjeroen on May 18, 2020, 14:02

Will be fixed in next release.

MR https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/merge_requests/270

cswendrowski commented 4 years ago

In GitLab by @yjeroen on May 18, 2020, 14:02

closed