foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
399 stars 333 forks source link

Untrained Improvisation #366

Closed cswendrowski closed 2 years ago

cswendrowski commented 4 years ago

In GitLab by @tecknojock on May 18, 2020, 15:45

There's no adequate way to do untrained improvisation within the character sheet. We need some way to apply half proficiency or full proficiency to untrained skills, or some method of providing a manual bonus.

https://2e.aonprd.com/Feats.aspx?ID=861

cswendrowski commented 4 years ago

In GitLab by @nikolaj-a on May 26, 2020, 19:26

You can do a macro like this:

const actor = game.actors.entities.find(c => c.data.name === 'Actor Name Here');

const level = actor.data.data.details.level.value;
const modifier = level < 7 ? Math.floor(level / 2) : level;
const untrained = Object.values(actor.data.data.skills).filter((skill) => skill.rank === 0) ?? [];

(async function applyModifiers() {
  for (const skill of untrained) {
    await actor.removeCustomModifier(skill.name, 'Untrained Improvisation');
    if (modifier > 0) {
      await actor.addCustomModifier(skill.name, 'Untrained Improvisation', modifier, 'proficiency');
    }
  }
})();

I have added it to the players' part of the wiki (https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/wikis/PF2E-Foundry-Game-System/For-Players)

cswendrowski commented 4 years ago

In GitLab by @tecknojock on May 27, 2020, 01:31

I get SyntaxError: "redeclaration of formal parameter actor" callScriptMacroFunction https://fvtt.derpyapps.org:2083/modules/furnace/Macros/Macros.js:171 renderMacro https://fvtt.derpyapps.org:2083/modules/furnace/Macros/Macros.js:192 executeMacro https://fvtt.derpyapps.org:2083/modules/furnace/Macros/Macros.js:216 _onClickMacro https://fvtt.derpyapps.org:2083/scripts/foundry.js:21317 jQuery 2

cswendrowski commented 4 years ago

In GitLab by @nikolaj-a on May 27, 2020, 04:28

That happens if you have TheFurnace module installed, as that will pre-declare the actor in macros. Remove the first line :)

cswendrowski commented 4 years ago

In GitLab by @nikolaj-a on Jun 17, 2020, 14:49

This has been addressed by https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/merge_requests/517

cswendrowski commented 4 years ago

In GitLab by @nikolaj-a on Jun 17, 2020, 14:49

closed