foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
418 stars 349 forks source link

Custom Martial Proficiencies in New Sheet are not togglable for proficiency + Strike Actions are bugged #441

Closed cswendrowski closed 2 years ago

cswendrowski commented 4 years ago

In GitLab by @elhomunkolus on May 26, 2020, 01:52

In the new character sheet you cannot toggle proficiency level for custom martial skills. You cannot delete them either. It however works for other skills and it works fine in the old sheet style.

Additionally changing proficiency for an item in the inventory does not change the proficiency bonus for the autogenerated strike action. I tried it with the dagger for the wizard, changing it to his wizard weapons and he still does not get any bonuses. This is how I originally discovered the problem with martial skills.

cswendrowski commented 4 years ago

In GitLab by @nikolaj-a on May 26, 2020, 18:32

The second part with the strikes is fixed by https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/merge_requests/402

cswendrowski commented 4 years ago

In GitLab by @hooking on May 26, 2020, 19:18

closed via merge request !403

cswendrowski commented 4 years ago

In GitLab by @hooking on May 26, 2020, 19:18

mentioned in commit f20a06c75eab15e97aa31cbf25f7e3279119347f