New Character Sheet - Untranslatable Text

[cswendrowski]

In GitLab by @danielrbs on May 26, 2020, 13:32

I'm currently working on the Brazilian Portuguese Translation for the PF2 system, and I noticed a lot of text in the next character sheet either doesn't have translatable strings in the language file, or is not using them correctly. All currently translatable strings are already translated, as of version 1.0.1. Here is a list of every case of this I noticed:

Sidebar:

• Armor Class (Big Blue Shield icon)
• Shield HP (Big Red Shield icon)
• Shield Max HP
• AC, H and BT (Small White Shield icons)
• Perception
• View Modifier button
• Resistances
• Weaknesses
• Immunities

Inside the View Modifiers Panel:

• Name of each category of modifier (Ability, Proficiency, Status, etc.)

Character Tab:

• Title of the Tab
• Deity
• Traits & Other Details
• Bonus HP
• Bonus HP details when you hover over it are also incorrectly showing the SP label instead
• B. HP / Level
• Key Ability
• Ability Score Acronyms (Str, Dex, Con, Int, Wis, Cha)

Actions Tab:

• Strikes (Experimental)
• Strike
• MAP

Inventory:

• Current Bulk, Encumbered and Max Capacity on the bottom bar

Spellbook:

• Proficiency
• Item
• The name of the proficiency level (Trained, Expert, etc.) actually gets invisible with the translated sheet
• Empty Slot (drag spell here)

Skills:

• Modifiers button
• The name of the proficiency level (Trained, Expert, etc.) actually gets invisible with the translated sheet

Biography:

• Title of the Tab

[cswendrowski]

In GitLab by @Noires on May 28, 2020, 10:41

I started working on supporting translations on those values and will soon create a MR for it.

Edit: See Mergerequest https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/merge_requests/420

[cswendrowski]

In GitLab by @Noires on May 28, 2020, 12:42

Finished

Based on: https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/issues/459

Sidebar:

• [x] Armor Class (Big Blue Shield icon) -> Localized with PF2E.ArmorClassShortLabel because of redundancy in header and small space.
• [x] Shield HP (Big Red Shield icon) -> Localized with PF2E.ShieldCurrentLabel
• [x] Shield Max HP -> Localized with PF2E.ShieldLabel and PF2E.MaxHitPointsShortLabel
• [x] AC, H and BT (Small White Shield icons) -> Localized with PF2E.ArmorClassShortLabel, PF2E.ShieldBTShortLabel(new) and PF2E.ShieldHardnessShortLabel(new). Replaced css labels with svg text elements.
• [x] Perception -> Localized with PF2E.PerceptionHeader
• [x] View Modifier button -> Localized with PF2E.ModifiersTitle(new)
• [x] Resistances -> Localized with PF2E.ResistancesLabel
• [x] Weaknesses -> Localized with PF2E.WeaknessesLabel
• [x] Immunities -> Localized with PF2E.ImmunitiesLabel

Inside the View Modifiers Panel:

• [x] Name of each category of modifier (Ability, Proficiency, Status, etc.) -> Localized with PF2E.ModifierType.XXX(new per type)

Character Tab:

• [x] Title of the Tab -> Localized with PF2E.TabCharacterLabel. Not sure if a different localization for each tab is really necessary or if it could just be called PF2E.CharacterLabel
• [x] Deity and Choose A Deity -> Localized with PF2E.Deity and PF2E.DeitySelectionPlaceholder(new) for selector
• [x] Bonus HP -> Localized with P2FE.BonusHPLabel(new)
• [x] Bonus HP details when you hover over it are also incorrectly showing the SP label instead -> Fixed
• [x] Bonus SP -> Localized with P2FE.BonusSPLabel(new)
• [x] B. HP / Level -> Localized with P2FE.FlatBonusHPperLevel(new)
• [x] B. SP / Level -> Localized with P2FE.FlatBonusSPperLevel(new)
• [x] Key Ability -> Localized with P2FE.KeyAbilityLabel(new) since P2FE.KeyAbility is reserved for "Key Ability Score"
• [x] Traits & Other Details -> Localized with P2FE.CharacterTraitsHeader(new)
• [x] Ability Scores -> Localized with P2FE.AbilityScoresHeader
• [x] Ability Score Acronyms (Str, Dex, Con, Int, Wis, Cha) -> Localized with P2FE.AbilityId.XXX(new for all abilities)

Inventory:

• [x] Current Bulk, Encumbered and Max Capacity on the bottom bar -> Localized with P2FE.BulkLabel,P2FE.ConditionTypeEncumbered and P2FE.BulkMaxLabel(new and renamed Max Capacity)

Actions Tab:

• [x] Strikes (Experimental) -> Localized with PF2E.StrikesLabel(new) and PF2E.Experimental(new)

Spellbook:

• [x] Proficiency -> Localized with P2FE.ProficiencyLabel(new)
• [x] The name of the proficiency level (Trained, Expert, etc.) actually gets invisible with the translated sheet -> Replaced text from scss with dynamic localization based on Proficiency value. Removed {{{entry.data.spelldc.icon}}} since it is from the old sheet.

Biography:

• [x] Title of the Tab -> Localized with PF2E.Biography

Skills:

• [x] The name of the proficiency level (Trained, Expert, etc.) actually gets invisible with the translated sheet -> Fixed with the same approach as for spells. But needs some review for the coloring of the spans in the scss.
• [x] Modifiers button -> Localized with PF2E.ModifiersTitle

Open changes for next MR:

Actions Tab:

• [ ] Strike
• [ ] MAP

Spellbook:

• [x] Item -> Seemed like it already was fixed.
• [ ] Empty Slot (drag spell here)

[cswendrowski]

In GitLab by @danielrbs on May 31, 2020, 16:55

First of all, thank you a lot for the great work on this! Here is a list with the leftovers/extra problems of the same kind I found after update 1.2.0, that are not already listed in "Open Changes for next MR":

Sidebar:

• Initiative
• "Modifiers" button text for Armor Class and Class DC
• Title of the modifiers popup for Armor Class and Perception

Inside the View Modifiers Panel:

• Modifier Name
• Pick a type
• Add
• Untyped (Penalty)

Spellbook:

• The name of the Spell Entries that combine multiple strings don't work properly in many languages. Ideally, there should be a way to make a separate string for each combination

Skills:

• Hovering over the buttons to create new Lore and Martial skills says "Create Action" instead of "Create Skill"

[cswendrowski]

In GitLab by @Shandyan on Jul 7, 2020, 09:12

marked this issue as related to #465

[cswendrowski]

In GitLab by @nikolaj-a on Dec 27, 2020, 12:34

mentioned in commit 73e1d34a053f17961a770783f14e04ecdda333c2