foundryvtt / pf2e

A community contributed game system for Pathfinder Second Edition.
https://foundryvtt.com/packages/pf2e
Apache License 2.0
399 stars 333 forks source link

Resistance to all damage dice in single attack not being applied properly, results in too much damage #6629

Closed sesopenko closed 1 year ago

sesopenko commented 1 year ago

When attacking with two damage types, ie: 1d6 pierce + 1d4 fire, if one damage die bypasses damage resistance the other damage die from the same attack will incorrectly bypass damage resistance too, causing too much damage on the target.

See rules explanation here, under Resistance

The text below is in the link above and also Core Rulebook 4th Printing page 453 (lower left corner of page)

It’s possible to have resistance to all damage. When an effect deals damage of multiple types and you have resistance to all damage, apply the resistance to each type of damage separately. If an attack would deal 7 slashing damage and 4 fire damage, resistance 5 to all damage would reduce the slashing damage to 2 and negate the fire damage entirely.

Steps to reproduce with an example combat scenario:

  1. Add a Fire Mephit to the play area
  2. Add a Vampiric Mist to the play area
  3. Start combat and roll initiative
  4. roll an attack for the Fire Mephit until it strikes
  5. Target the Vampiric Mist and click the Damage button for the attack in the Chat log

Expected Result:

The 1d6 pierce should have the physical 5 damage resistance applied to it and the 1d4 fire should bypass the physical 5 damage resistance.

Actual result:

Both the piercing and fire damage bypass the physical 5 damage resistance, resulting in damage rolls up to 10 damage being fully applied to the target. Too much damage occurs for the target.

You can see the log in the screenshot attached here, where too much damage was applied because the pierce damage bypassed the physical damage. It should have only received 3 damage, because the 5 pierce wasn't enough to bypass the DR 5 physical.

damage resistance bug

simonward commented 1 year ago

If you hover over the (i) symbol, what do you see? My expectation is that it took -5 physical, +5 fire. (5-5 = 0 piercing)+(3+5 = 8 fire) = 8

sesopenko commented 1 year ago

Oh my, I just realized that the vampiric mist has 5 fire weakness, which means it takes 5 bonus points of fire damage whenever it takes fire. Things are working as expected, sorry for the trouble! Sorry, we're all in our group learning Pathfinder 2e as we go!