foundryvtt / unfulfilled-rolls

A module that allows individual rolls to be fulfilled by other sources
MIT License
3 stars 5 forks source link

Exploding dice explode only once #14

Open kristianserrano opened 1 year ago

kristianserrano commented 1 year ago

Disclaimer: This came up while testing my GoDice with the Savage Worlds Adventure Edition (SWADE) system.

When rolling exploding dice either off of a SWADE character sheet or manually in the chat, the dice explode properly on the first explosion, but any subsequent explosions aren't recognized. For example, rolling a 6 on a d6, if the following roll also rolls a 6, the result stops at 12 rather than rolling again.

Irvanya commented 1 year ago

I also see this in testing and additionally the exploded die always uses the Foundry roller instead of prompting for another roll of the physical dice.

kristianserrano commented 1 year ago

I also see this in testing and additionally the exploded die always uses the Foundry roller instead of prompting for another roll of the physical dice.

Which I honestly saw as a bug as well, but it was kind of neat to roll the first one and watch it explode on its own like it was a surprise.

Irvanya commented 1 year ago

This appears to be fixed in 0.1.3. Exploding dice still use the internal roller, but can explode more than once. Verified with manual entry of the dice roles, will double check using Go Dice later today.