search

foundryvtt / unfulfilled-rolls

A module that allows individual rolls to be fulfilled by other sources
MIT License
3 stars 5 forks source link

[Bug 0.1.3] Incompatibility With Macro "Chained" Dice Rolls (PF2e) #32

Open 117ksk opened 1 year ago

117ksk commented 1 year ago

Various macros that might call multiple "chained" rolls to occur either get skipped or simply get suck and require a reload to fix.

Example 1:

PF2e Workbench module Treat Wounds When using the Treat Wounds macro a d20 roll is expected followed by d8 rolls of healing/damage depending on degree of success of d20 roll (1, 2, or 4).

Using Unfulfilled Rolls, the first d20 roll is prompting input as expected, but then immediately opens and closes the d8 prompt and exits without rolling any d8s.

Without Unfulfilled Rolls: https://github.com/foundryvtt/unfulfilled-rolls/assets/113755707/7f91f27b-cd6d-49de-b5fc-a95d0b8a3097

With Unfulfilled Rolls: https://github.com/foundryvtt/unfulfilled-rolls/assets/113755707/65c3c790-f6e3-4106-b402-afadb210ebaa


Example 2:

PF2E Action Support module Double Slice When using the Double Slice macro two attack rolls are intended to be rolled and damage combined based on the outcome of the rolls.

Using Unfulfilled Rolls, the first attack is rolled as expected with a popup requesting the input. However, no more rolls are asked for and the macro appears to simply get stuck. No further damage rolls nor normal attacks can be made until a reload is completed and macro is dropped out of.

Without Unfulfilled Rolls: https://github.com/foundryvtt/unfulfilled-rolls/assets/113755707/a33e8eac-c929-4bd1-8115-4b4353286d55

With Unfulfilled Rolls: https://github.com/foundryvtt/unfulfilled-rolls/assets/113755707/d53c9f93-e037-49bb-91a3-579d34744d04

Plushtoast commented 1 year ago

this macro can reproduce the issue:

let roll = await new Roll("1d20").evaluate({async:true})
roll = await new Roll("1d20").evaluate({async:true})

the second dialog won't be shown

117ksk commented 1 year ago

It looks like this issue happens in many instances in which a macro would roll consecutive rolls. Such as rolling a D20 for a flat DC 5 check due to concealment before rolling a D20 against AC to hit right after. Any modules that have this functionality or any macros made cause Unfulfilled Rolls to simply fail and not prompt after the first roll.