search

foundryvtt / unfulfilled-rolls

A module that allows individual rolls to be fulfilled by other sources
MIT License
3 stars 5 forks source link

No button in settings tab to "Open Dice Configuration" #4

Closed ceejii closed 1 year ago

ceejii commented 1 year ago

I installed a local Foundry server, added the system dnd5e, added the module unfullfilled-rolls v 0.0.2. Started up, created a dnd5e world and activated unfulfilled-rolls module and restarted server.

I don't get the "Open Dice Configuration" button on the right. image Did not get any errors in console. Asked on Discord but no luck.

The day after (today) I DO get an error message: image

I don't know Github Actions and do not have a full setup to test fixes. But, looking at .github/workflows/main.yml it looks to me like the apps folder is not added to the package when zipping, which would explain the error above, I think. https://github.com/foundryvtt/unfulfilled-rolls/blob/a39995d217a74a05f022b173d223fb149de2c224/.github/workflows/main.yml#L113

As a side note, the zip also mentions a language folder but in the repo the folder is named languages (note the trailing s) so maybe that is also a problem.

I'm new to Foundry dev so I'm sorry if I'm jumping to incorrect conclusions.

ceejii commented 1 year ago

Did some more testing and found that it appears that the apps folder is not packaged so I added that and the translations folder to the Github main action. Created a pull request. https://github.com/foundryvtt/unfulfilled-rolls/pull/5