foundryvtt / world-anvil

A module to integrate World Anvil with Foundry Virtual Tabletop.
MIT License
12 stars 7 forks source link

There may be some features you will be interested in #31

Closed cswendrowski closed 2 years ago

cswendrowski commented 2 years ago

In GitLab by @adrien.schiehle on Sep 20, 2021, 06:11

I forked 6 month ago, when I created the issue #28 .

I couldn't find how to apply merge request on the main repository, so I created my own one. The idea of integrating Foundry and World Anvil is great, but there was some little things which were missing for my needs.

Since I found it fun to upgrade it to my needs, the list of features that I integrated became somehow pretty large. And I don't know if all of them should be merged inside the main module:

Most of the developed features can be activated through the module configuration screen. I tried to let the default behavior the same as it currently is.

List of main features :

Teaser here : https://gitlab.com/adrien.schiehle/world-anvil/-/blob/article_shortcuts/README.md

The drawback of this fork is that the changes have become somewhat massive and it may be some work to only review them.

If there are some features the community is interested in integrating, I can try to make some smaller MR, and we will integrate features one by one. ( I will need to have the right to create MR then :angel: )

cswendrowski commented 2 years ago

Hey @adrien.schiehle - I would like to work with you on this. These are good improvements and I've been hoping to find a community contributor who can help me maintain the WA module.

As you say, there is a lot of code here that would be too much to review and merge directly, so I hope we could work together to figure out a strategy to merge this functionality one piece at a time. Would it be possible to connect on Discord and start a chat to figure out a plan for implementing some improvements?

You should already have permission to submit merge requests, as the project is configured to allow merge requests to be created by "Everyone With Access".

cswendrowski commented 2 years ago

In GitLab by @adrien.schiehle on Sep 20, 2021, 12:50

That would be my pleasure.

For the merge request access, I will look a little more. It seems problem comes from the way I usually clone my projects (https instead of git@gitlab )

Like you will see, I'm pretty comfortable with how git works, but I'm a real newbie when it comes to how community projects operates. (I used git on my real job but I still have no community contribution)

I will message you on discord a little later.

cswendrowski commented 2 years ago

Closing this meta-issue since we are working together on the individual issues in the list!