search

foundryvtt / world-anvil

A module to integrate World Anvil with Foundry Virtual Tabletop.
MIT License
12 stars 7 forks source link

Fix null content import error - [closed] #52

Closed cswendrowski closed 2 years ago

cswendrowski commented 2 years ago

In GitLab by @mod100 on Feb 2, 2022, 04:02

Merges master -> master

I hit an error when trying to import my WorldAnvil content because of this line (252) in framework.js.

const isLongContent = section.content.length > 100;

In some cases section.content is null and so this line fails, hence the change.

cswendrowski commented 2 years ago

In the case that section.content is null as you describe, do we have section.content_parsed that we will need on line 261, or is there going to be a further failure later down the line?

cswendrowski commented 2 years ago

In GitLab by @NickM2402 on Feb 2, 2022, 09:54

I was just looking for help on the fvtt discord because of this I believe. When trying to import I'm getting this in Chrome

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'length') at getArticleContent (framework.js:252:45) at importArticle (framework.js:108:19)

Or this in Firefox:

Uncaught (in promise) TypeError: section.content is null getArticleContent https://mydomainhere/modules/world-anvil/module/framework.js:252 importArticle https://mydomainhere/modules/world-anvil/module/framework.js:108 [...]

Weirdly enough, I can't import ANY of my articles and always get this error no matter what I try. Did something change recently, maaybe in regards to the WA API? I can't imagine this being unnoticed for 2 months since 1.3.1 released

cswendrowski commented 2 years ago

In GitLab by @mod100 on Feb 2, 2022, 10:08

Commented on module/framework.js line 252

When I checked in my import job, content_parsed always existed and was just an empty string, even when content was null.

cswendrowski commented 2 years ago

In GitLab by @mod100 on Feb 2, 2022, 10:10

Hi @NickM2402 yes, this is the same error that I found, that I think the change above resolves.

cswendrowski commented 2 years ago

It sounds like this is a new issue related to an update just pushed (today) on the WA side. I mentioned it to Dimitris and he thinks he can resolve it on his side without us needing to make a code change. Let's sit tight for a couple hours and see what happens.

cswendrowski commented 2 years ago

In GitLab by @NickM2402 on Feb 2, 2022, 11:06

This issue seems to be resolved for me. Working flawlessly now :) Thank you and give Dimitris my thanks!